search

flxbe / asm-space-invaders

A small, bootable game written in x86 Assembly inspired by Space Invaders
MIT License
214 stars 13 forks source link

Fix #12:Clean up some define macros #13

Closed cyblue9 closed 5 years ago

cyblue9 commented 5 years ago

It corresponds to #12 .

Best regards,

cyblue9 commented 5 years ago

@flxbe Please review the proposed changes!

cyblue9 commented 5 years ago

Should all constants be included in space-invaders.asm or should they be split into each file? What do you think if you consider readability?

flxbe commented 5 years ago

Since the amount of constants is still very manageable I would prefer to put them all into space-invaders.asm.

cyblue9 commented 5 years ago

Thank you for review!!

Since the amount of constants is still very manageable I would prefer to put them all into space-invaders.asm.

OK, I agree with.

Please, Re-review!