search

flxbe / asm-space-invaders

A small, bootable game written in x86 Assembly inspired by Space Invaders
MIT License
215 stars 13 forks source link

Project Direction #19

Open flxbe opened 5 years ago

flxbe commented 5 years ago

so, I want to spent more time on this project in the future.

I have some feature idea.

Other than this project

Your code is nice and there are many things to learn! Let's do the project for a long time!

Originally posted by @blue-9 in https://github.com/flxbe/asm-space-invaders/pull/18#issuecomment-433607742

flxbe commented 5 years ago
  • Coding other than x86 assembly

Do you mean targeting different platforms or adding support for a higher languange like C? I personally would love to port the project to an ARM architecture in order to support the Raspberry Pi. Starting the game in an emulator is nice, but executing it on a bare metal system seems unlikely to me. It would be awesome if it becomes practical to execute the game on a real system.

Regarding higher languages, I am having a hard time to make up my mind. I would love to see how far this project can get using only assembly. On the other hand, introducing a language like C, C++ or rust would certainly be a very educating experience as well. And the "user experience" would very likely also benefit from a higher level language.

cyblue9 commented 5 years ago

Nice, Issue.

Do you mean targeting different platforms or adding support for a higher languange like C?

I'm sorry about the hard-to-understand writing style. It means "target different platforms"!(ARM, MIPS, ・・・etc)

I personally would love to port the project to an ARM architecture in order to support the Raspberry Pi.

Nice idea. Before, I programed bare metal of Raspberry Pi and It was very wonderful experience. In that time, I used C, so writing Assembly all of system would be better experience.

Regarding higher languages, I am having a hard time to make up my mind.

I think so too.

flxbe commented 5 years ago

Hi! I just wanted to give a little update update regarding my current situation. I finally finished by thesis, but am already working on a work-related project. I do have a few free days upcomming, but due to the quite stressful last weeks I would rather not commit to any fixed agenda for this project.

Personally, I would love to dive deeper into several of the topics we mentioned. I can however only invest time on a spontaneous basis. Therefore, I would veto great architectural changes like the raspberry pi or another programing language. The same is true for any additional projects like game packs or educational material. I sadly do not have the time right now.

I would however love to slowly add new features to the current game. For me, obvious candidates are game colors and the score, which you already mentioned.

I totally understand if you have other plans. Feel free to fork the project and go into a different direction. I would be happy to mention your repository at the top of my README as some type of "official" fork.

Otherweise, I would of course be happy to work together on new features in the future. What do you think?

cyblue9 commented 5 years ago

Hi @flxbe ! Long time no see! 😀

I just wanted to give a little update update regarding my current situation. I finally finished by thesis, but am already working on a work-related project. I do have a few free days upcomming, but due to the quite stressful last weeks I would rather not commit to any fixed agenda for this project.

You must be tired by thesis. Good job! Please refresh by all means. 😴

Personally, I would love to dive deeper into several of the topics we mentioned. I can however only invest time on a spontaneous basis. Therefore, I would veto great architectural changes like the raspberry pi or another programing language. The same is true for any additional projects like game packs or educational material. I sadly do not have the time right now.

OK.

I would however love to slowly add new features to the current game. For me, obvious candidates are game colors and the score, which you already mentioned. I totally understand if you have other plans. Feel free to fork the project and go into a different direction. I would be happy to mention your repository at the top of my README as some type of "official" fork. Otherweise, I would of course be happy to work together on new features in the future. What do you think?

Yes! I love this project! So, I want to work together too. 😄

I am still interested in game color and score. Shall we be targeted them in the short term?

Let's update this project little by little!!!

flxbe commented 5 years ago

Nice to hear you are still interested!

I would recommend to assign each feature to either one of us. Then we can take the time we want to implement the features and at the same time not slow the other down. I would make code reviews a necessary step in the workflow. If you are okay with it, I would add you as a contributor with merge priviliges. However, I would like to protect the master branch and only allow merges after one of us has approved a pull request.

I will create issues for the features we mentioned so far. Just assign yourself to one of them, if you want to work on it. I will probably have time to write some code (finally!) starting at the 28th.

I would leave this issue open for future discussions. I am looking forward to implement some features!

cyblue9 commented 5 years ago

Hi @flxbe !

I would recommend to assign each feature to either one of us. Then we can take the time we want to implement the features and at the same time not slow the other down. I would make code reviews a necessary step in the workflow.

Thank you to propose about workflow in the future. It's a good idea!

If you are okay with it, I would add you as a contributor with merge priviliges.

Of course OK! 😊

However, I would like to protect the master branch and only allow merges after one of us has approved a pull request.

Agree. 🙆🏻‍♂️

I will create issues for the features we mentioned so far. Just assign yourself to one of them, if you want to work on it. I will probably have time to write some code (finally!) starting at the 28th.

Thank you to create issues! OK, I will assign myself to Interesting issue. I'm looking forward your code!

I would leave this issue open for future discussions. I am looking forward to implement some features!

I think so too!!! 😆