flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
29 stars 15 forks source link

fix(dependency:resolver): missing dependencies due to package directory order #107

Closed azlam-abdulsalam closed 2 months ago

azlam-abdulsalam commented 2 months ago

Fixes #97

Checklist

All items have to be completed before a PR is merged

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: dieffrei
:white_check_mark: azlam-abdulsalam
:white_check_mark: zhebinliu
:x: azlam


azlam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.49%. Comparing base (2bd58ec) to head (7799ab7). Report is 50 commits behind head on main.

Files Patch % Lines
src/core/project/UserDefinedExternalDependency.ts 33.33% 4 Missing :warning:
src/core/project/ProjectConfig.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================== - Coverage 46.36% 45.49% -0.87% ========================================== Files 73 71 -2 Lines 2836 3299 +463 Branches 328 714 +386 ========================================== + Hits 1315 1501 +186 - Misses 1496 1661 +165 - Partials 25 137 +112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.