flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
31 stars 18 forks source link

Error in picklist deployer when deploying a value with a percentage #110

Open dinhphieu opened 3 months ago

dinhphieu commented 3 months ago

Describe the bug Picklist Enabler predeployment step fails when a picklist with a percentage value is provided It fails with the message "Unable to process pre deploy for Picklist Enabler due to Unable to process Picklist update due to URI malformed"

To Reproduce Steps to reproduce the behavior:

Expected behavior Deployment of picklist values with percentages goes through

Screenshots Error: image

Example of the value set: image

Platform Details (please complete the following information): @scc/sfp/38.5.5 win32-x64 node-v20.10.0

Additional context Upon further inspection, it seems like this is the root cause: src/core/package/deploymentCustomizers/PicklistEnabler.ts:183 image The "%" in "20%" gets treated as an escape char in decodeURI()

dieffrei commented 3 months ago

@dinhphieu I could reproduce the bug, I'm working a fix