flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
31 stars 18 forks source link

fix: remove encode/decore uri on picklist values #113

Closed dieffrei closed 1 week ago

dieffrei commented 3 months ago

I have done some tests and notice that values coming from tooling api API they already come decoded, no needed for decode/encondingURI. I assume that source-retrieve lib already handles this encoding.

Screenshot 2024-08-25 at 13 36 57

As described in the image above, the value is already decoded, when trying to decode, you get the error "URI malformed"

I create a draft PR, to have some earlier feedback. It still requires more testing

Checklist

All items have to be completed before a PR is merged

typo-app[bot] commented 3 months ago

Typo Code Review 📊

✅ All checks passed!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.49%. Comparing base (2bd58ec) to head (252283a). Report is 65 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== - Coverage 46.36% 45.49% -0.87% ========================================== Files 73 71 -2 Lines 2836 3299 +463 Branches 328 714 +386 ========================================== + Hits 1315 1501 +186 - Misses 1496 1661 +165 - Partials 25 137 +112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.