flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
31 stars 18 forks source link

Vlocity-Data-Package crashes sfp deployment #115

Open Schuchie opened 2 months ago

Schuchie commented 2 months ago

Describe the bug A vlocity-data-package can break the whole deployment process, when it contains a xml-file which isn't a metadata. In specific the pre and post deployers are not handling that case correctly.

To Reproduce Steps to reproduce the behavior:

  1. Add a sfdx-package as type data
  2. Insert a datapack with a random .xml-File
  3. Try to deploy/create pool.

Expected behavior Deployment or Pool Creation should work without any issue. The pre-/post-deployers should not break with such a kind package.

Screenshots image

Platform Details (please complete the following information):

Additional context Workaround: Just ignore the whole datapacks via .forceignore. (maybe the correct approach for datapacks?)

Following code runs into an error, when a xml file is contained in a datapack:

// sfp/src/core/package/packageInstallers/InstallPackage.ts:313
// sfp/src/core/package/packageInstallers/InstallPackage.ts:360

let componentSet = ComponentSet.fromSource(
    path.join(this.sfpPackage.projectDirectory, this.sfpPackage.packageDirectory)
);