flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
31 stars 18 forks source link

fix: error in windows "Error: EPERM: operation not permitted, unlink" #134

Closed dinhphieu closed 2 weeks ago

dinhphieu commented 1 month ago

Checklist

All items have to be completed before a PR is merged

dinhphieu commented 1 month ago

Resolves https://github.com/flxbl-io/sfp/issues/128 @azlam-abdulsalam

After some investigation, I found that the issue only occurs on Windows because unlink and rmdir operations are not atomic there

Refs: https://github.com/isaacs/rimraf/issues/102#issuecomment-207715075 https://www.npmjs.com/package/rimraf (rimraf.windows and rimraf.moveRemove sections) https://superuser.com/a/1796069

azlam-abdulsalam commented 1 month ago

Thanks @dinhphieu