flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
31 stars 18 forks source link

fix(sfppackage): fix handling of URL-encoded spaces in repository URLs #138

Open richard-giraud opened 2 weeks ago

richard-giraud commented 2 weeks ago

This fixes #137

If the repository URL includes an URL-encoded space (i.e., %20), sfp install will fail to parse it. The user is presented with a rather unhelpful message:

Error: URL parsing failed.

This PR makes 2 changes:

Error: Invalid repository URL for package '$PACKAGE_NAME': $REPOSITORY_URL

Screenshot from 2024-11-08 09-10-53

A test was added to support the problematic case.

Checklist

All items have to be completed before a PR is merged

richard-giraud commented 1 week ago

I need a little help figuring out how to make Codacy happy. I don't believe that I've introduced any new issues, and I'm not sure what needs to be done to address its concerns.

richard-giraud commented 1 week ago

It looks like this may be a limitation of how Codacy is configured/works.

I reported a blocking bug at https://github.com/flxbl-io/sfp/issues/140

richard-giraud commented 6 days ago

I've expanded the patch to include the fix for the issue.