flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
29 stars 15 forks source link

sfp is not respecting multiple force ignore files #37

Closed azlam-abdulsalam closed 1 month ago

azlam-abdulsalam commented 7 months ago

Describe the bug sfp doesnt respect multiple force ignore files when the sfdx-project.json is defined with plugins.sfpowerscripts.ignoreFiles parameter in sfdx-project.json

To Reproduce Use the multiple force ignore feature using plugins.sfpowerscripts, note that this components are not correctly ignored

Expected behavior Need to retain backward compatibility

Screenshots If applicable, add screenshots to help explain your problem.

Platform Details (please complete the following information):

Additional context The same works withplugins.sfp.ignoreFiles

domrycz commented 4 months ago

Hey guys, I've recently encountered this bug on validate command. I've changed the structure in sfdx-project.json and now part related to ignore files looks like this:

"plugins": { "sfp": { "ignoreFiles": { "prepare": "forceignores/.prepare-ignore", "validate": "forceignores/.validate-ignore", "quickbuild": "forceignores/.quickbuild-ignore", "build": "forceignores/.build-ignore" } } }

The problem is that after I've changed from plugins.sfpowerscripts.ignoreFiles to plugins.sfp.ignoreFiles it started working for validate and build but it doesn't work for prepare (and the content of .prepare-ignore and .validate-ignore is the same). In docs you have examples only for build and validate - could you check if my structure is valid also for prepare? I'm using sfp pool prepare command.

azlam-abdulsalam commented 1 month ago

@domrycz can you confirm for the newer versions

azlam-abdulsalam commented 1 month ago

Closing this