flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
26 stars 12 forks source link

Aliasfy Packages are ignored in the Pool Preperation #44

Open Schuchie opened 4 months ago

Schuchie commented 4 months ago

Describe the bug Aliasfy packages are filtered from the pool preparation command through the following change:

To Reproduce Steps to reproduce the behavior:

  1. Have a aliasfy package in the sfdx-project.hson and executed the pool preparation command without an release-config:
  2. sfp orchestrator:prepare -f config/project-ci-stage-pool-def.json -v devhub --loglevel trace
  3. The builded packages does not contain any aliasfy package

Expected behavior Aliasfy packages are included in the pool creation. It should take the "default"-Package if exists.

Screenshots If applicable, add screenshots to help explain your problem.

Platform Details (please complete the following information):

Additional context The following line of code is filtering aliasfy packages in the pool creation:

dieffrei commented 3 months ago

@azlam-abdulsalam any thoughts, on this one? I think it makes sense, usually, you could have a default configuration you want to deploy to scratch orgs

dieffrei commented 2 weeks ago

@Schuchie fyi this feature will be available on aliasifyv2, however, there is no ETA yet, as it is under development.