search

flxbl-io / sfp

A build system for modular development in Salesforce
https://docs.flxbl.io/sfp/
MIT License
26 stars 13 forks source link

sfp validate org command deploys the package expected to only validate #94

Closed GaneshSMC closed 1 month ago

GaneshSMC commented 2 months ago

We have been utilizing sfp to setup an CI process in our workflow we have the following command sfp validateAgainstOrg -o DEV_SB -v DEV_SB --basebranch=origin/main --diffcheck --coveragepercent 95 --mode=fastfeedback this command deploys the package

Expected behaviour: we expect only to validate not to deploy the package/components

Documents Screenshots: image image From these document on our understanding the sfp document says validate is utilized to validate a change also further it says it will validate by deploying.

We utilized to it expecting that it will only validate against our target dev org but its deploying the package even though any apex test fails.

Validate Test - with Apex test passed image Validate test - with Apex test failed image

On both the case the package gets deployed. We expect only to validate not to deploy the package/components. We aren't clear about what's the actual behaviour of sfp validate org command. Could you clarify about this to us!

dieffrei commented 1 month ago

Hi @GaneshSMC the command works the same as scratch org pooling validation, the code/metadata is deployed (it doesn't use the only-validation traditional flag). There is no support to "only validate" deployment on SFP.