search

fly-apps / dockerfile-laravel

20 stars 1 forks source link

Create Tests to run that will be checked before allowing for merge #26

Closed KTanAug21 closed 7 months ago

KTanAug21 commented 7 months ago

What: Create Test that can later be used in the pipeline to allow/block merges.

Why: The current repository is vulnerable to new changes as no existing tests are available to tell whether the new changes will break any previous ones.

Notes: We can get inspiration from earlier dockerfile generators here!

KTanAug21 commented 7 months ago

Considerations:

There has to be a means of easily determining the templates to generate for each test case This can be done by basing generation of templates from options scanned/selected IN a testing environment, other dockerfile generators make use of a file to determine the options used during generation: JS - test/dir/package.json Rails - config/dockerfile.yml For the Laravel dockerfile generator, maybe this can be in test/dir/composer.json?

OH! Finally found the reason why thanks to @rubys ! Turns out it boiled down to whether the file allowed unknown options to be preserved. package.json allowed this, while Gemfile didn't.