search

fly-apps / dockerfile-laravel

19 stars 1 forks source link

(Didn't need to!)Add Entrypoint to Dockerfile to start the application server #3

Closed KTanAug21 closed 7 months ago

KTanAug21 commented 7 months ago

The current Dockerfile template used in the repository ends at EXPOSE 8080.

I'm not sure yet whether this starts the server or not though, gonna do some testing. After testing, I should be able to identify whether the Dockerfile starts a server or not. If it does not, Run a command that will run the server.

fideloper commented 7 months ago

hi! The base image defines the entrypoint, I took it out of the Dockerfile here as I think it was actually redundant (although definitely confirm that yourself, I could be wrong!)

KTanAug21 commented 7 months ago

hi! The base image defines the entrypoint, I took it out of the Dockerfile here as I think it was actually redundant (although definitely confirm that yourself, I could be wrong!)

Hi @fideloper !!! Oh I see! Yup I can see there's an ENTRYPOINT in laravel-docker, didn't think to look at that file before. Thanks for the save!

KTanAug21 commented 7 months ago

Closing this as the Dockerfile generated makes use of the laravel-docker repository's published image, which does declare an ENTRYPOINT for starting the server.

Thanks @fideloper !