Node being installed even if Bun is being used

fly-apps / dockerfile-rails

Provides a Rails generator to produce Dockerfiles and related files.

MIT License

455 stars 38 forks source link

Node being installed even if Bun is being used #70

Closed luizkowalski closed 6 months ago

luizkowalski commented 6 months ago

hey 👋🏻

I see this issue where node is installed in the image and .node-version is generated even if Bun is being used. This can cause problems, as I found before.

I think that using_node? method just checks for package.json existence which is not 100% correct since Bun also uses this. I believe that using_node? should also check I'm not using_bun?

rubys commented 6 months ago

Care to make a pull request? Unless it breaks an existing test, I'll merge it.

luizkowalski commented 6 months ago

Sure, opened up one in draft, and will pick it up tomorrow, almost the next day here on the other side of the ocean hahaha