search

fly-apps / fly-laravel

Run your Laravel apps on Fly
40 stars 3 forks source link

Fixed most warnings and update code structure of LaunchCommand.php #49

Closed Johannes-Werbrouck closed 1 year ago

Johannes-Werbrouck commented 1 year ago

this fixes #38 , among other things.

KTanAug21 commented 1 year ago

great work @Johannes-Werbrouck!

Can you also check if the function getOrganizationName can be moved over to the FlyIoService class ? it's called and declared in the same manner in all of the launch commands, so it would be good to get it declared from one place

Johannes-Werbrouck commented 1 year ago

great work @Johannes-Werbrouck!

Can you also check if the function getOrganizationName can be moved over to the FlyIoService class ? it's called and declared in the same manner in all of the launch commands, so it would be good to get it declared from one place

I've fixed this in PR #52