The original icon fix assumed that the <svg> tag had an alt attribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, set aria-hidden="true" by default and require it to be overridden if needed.
chrismccord
commented
2 years ago
The original icon fix assumed that the
<svg>tag had analtattribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, setaria-hidden="true"by default and require it to be overridden if needed.