Hide title/artist metadata when empty.

fly-apps / live_beats

MIT License

1.28k stars 163 forks source link

Hide title/artist metadata when empty. #18

Closed ndarilek closed 2 years ago

ndarilek commented 2 years ago

From an accessibility perspective, having an empty <h2/> is confusing. Even though it lacks text, it remains visible to scree readers and is still navigable.

I'm not sure whether wrapping the entire <div/> in this check breaks the layout, or if the individual elements should have aria-hidden set if their values are empty.

ndarilek commented 2 years ago

Any updates on this? Ax is flagging it as a minor issue--would like to merge if possible.

Thanks!

chrismccord commented 2 years ago

❤️❤️❤️🐥🔥