fly-apps / redis

Launch a Redis server on Fly
79 stars 37 forks source link

official doc is not working #11

Open sg552 opened 2 years ago

sg552 commented 2 years ago

This is not an issue about this project, but about the official doc. ( https://fly.io/docs/reference/redis/

The Official doc for running a new REDIS is totally not working, it would generate an incorrect fly.toml and doesn't work.

I spent hours until I found this demo project, and its fly.toml is correct

Please contact related employee to fix the bug, thanks ~

sg552 commented 2 years ago

for more info, the official doc would generate a incorrect fly.toml looks like:

# fly.toml file generated for pnsredis on 2022-06-03T17:05:03+08:00
app = "pnsredis"

kill_signal = "SIGINT"
kill_timeout = 5
processes = []

[build]
  image = "flyio/redis:6.2.6"

[env]

[experimental]
  allowed_public_ports = []
  auto_rollback = true

[[services]]
  http_checks = []
  internal_port = 8080
  processes = ["app"]
  protocol = "tcp"
  script_checks = []

  [services.concurrency]
    hard_limit = 25
    soft_limit = 20
    type = "connections"

  [[services.ports]]
    force_https = true
    handlers = ["http"]
    port = 80

  [[services.ports]]
    handlers = ["tls", "http"]
    port = 443

  [[services.tcp_checks]]
    grace_period = "1s"
    interval = "15s"
    restart_limit = 0
    timeout = "2s"
  [[mounts]]
    destination = "/data"
    source = "redis_server"
shymega commented 10 months ago

This looks like the documentation page has been superseded by the hosted Redis instance. Maybe this issue can be closed now?