flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
5.09k stars 1.11k forks source link

[BUG] FCU value reset happens too fast #3604

Closed leonlehmann closed 3 years ago

leonlehmann commented 3 years ago

Mod Version master

Describe the bug After changing HDG /TRK or V/S the windows resets to dashed display mode after just 5 seconds. In the real Airbus this happens after 45 seconds for HDG /TRK and VS/FPA and after 10 seconds for SPD/MACH.

To Reproduce

  1. AP on
  2. V/S mode
  3. set a vertical speed but don't engage yet
  4. the V/S window resets after just 5 seconds

Expected behavior The HDG/TRK and VS/FPA windows should reset to the dashes after 45 seconds and the SPD/MACH windows should reset after 10 seconds.

References

Was this working before/when did the issue start occurring? No.

Discord username (if different from GitHub): ll3hm4nn#4549

leonlehmann commented 3 years ago

I am already digging into the FCU code. Can someone please assign me for this issue? I would like to contribute :-)

Awemeter commented 3 years ago

You don't need to be assigned just make a pr and state you are fixing this issue. If you need help making a pr check out the contributing.md or ask in dev support in the server.

lukecologne commented 3 years ago

Before you work on anything: The video from A320 sim pilot is from the custom autopilot branch, in which this issue is already fixed

leonlehmann commented 3 years ago

@lukecologne alright, sorry I didn't notice that. Should we cherry pick this over into a new PR for master or just wait for the custom autopilot branch to land?

aguther commented 3 years ago

@lukecologne alright, sorry I didn't notice that. Should we cherry pick this over into a new PR for master or just wait for the custom autopilot branch to land?

I think it's not much to be changed to increase the timeout, question is more if there are not any additional issues happening then.

Just doing a cherry pick will not work, because on the custom Autopilot branch there was more change to the FCU to fix also other issues with it. For example it needs to take into account states from that system and those are not available on the master branch.

leonlehmann commented 3 years ago

@aguther I just had a glance on your custom-ap branch. Just a quick suggestion: To implement it like stated in FCOM, backToIdleTimeout also needs to be implemented and set to 10s for SPD/MACH in A320_Neo_FCU_Speed.

As I could see, TRK/HDG and VS/FPA are already set to 45s. That's great!

aguther commented 3 years ago

Up to now I did not touch the speed, but you're right. At some point I would also like to fix the scrolling of speed (to it's consistently changing 1 kn instead of sometimes 10 and sometimes 1).