flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
5.07k stars 1.1k forks source link

METAR via IVAO broken #6829

Closed FRYYYYYY closed 2 years ago

FRYYYYYY commented 2 years ago

Aircraft Version

Development

Build info

{
  "built": "2022-03-01T16:52:36+00:00",
  "ref": "master",
  "sha": "d3b9189b947866bf37ab5a96e332980fdd26758b",
  "actor": "frankkopp",
  "event_name": "manual",
  "pretty_release_name": "master:d3b9189b"
}

Describe the bug

The METAR display and request does not work once IVAO is selected as the network.

The following error message is displayed within the EFB: "TypeError: undefined is not an object (evaluating 'metarString.trim')"

2022-03-02 (4)

Within the MCDU, the request is broken:

2022-03-02 (5)

Expected behavior

In previous versions it was possible to display METAR via IVAO. It works via VATSIM etc., but not via IVAO.

Steps to reproduce

EFB

  1. EFB configured to "IVAO" (Settings --> ATSU/AOC)
  2. Load flight plan "FROM SIMBRIEF"

MCDU

  1. Request weather via MCDU menu

References (optional)

No response

Additional info (optional)

No response

Discord Username (optional)

No response

aguther commented 2 years ago

Please retest with development version and reopen the ticket if issue persists.

The experimental version is not supported and issues should be reported in Discord.

FRYYYYYY commented 2 years ago

Same behavior in the development version. @aguther : I am not able to re-open the issue.

Benjozork commented 2 years ago

IVAO have deprecated the METAR API we use.

We are awaiting on a key from them to switch to the new one. In the mean time, we are deploying a server-side change that will fallback to VATSIM to prevent errors.

Benjozork commented 2 years ago

Closing as further changes will be server-side.