search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

chore: adapt rust build to SU15 #8627

Closed Saschl closed 4 weeks ago

Saschl commented 2 months ago

Fixes #[issue_no]

Summary of Changes

Updates rust build to align with SU15 changes.

Instead of using the provided libc of the rust target we link against the MSFS_SDK version as it contains some differences to the official version. Visible changes are the availability of the memory debug window in the sim and the removal of warnings in the console.

Only to be merged after dev-env update and SU15 release.

Screenshots (if necessary)

References

https://github.com/rust-lang/rust/blob/00ed4edb44ccc76d8cc992ef9f9f4634ea6d0e82/compiler/rustc_target/src/spec/targets/wasm32_wasip1.rs#L29

https://doc.rust-lang.org/rustc/codegen-options/index.html#link-self-contained https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes

Additional context

Discord username (if different from GitHub):

Testing instructions

Load up the plane C&D, start it up and ensure the systems work as usual. Perform a takeoff and observe any erratic behavior (not being able to control the plane, check Hyd ECAM page if the values are in normal range).

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
LunakisDev commented 4 weeks ago

Quality Assurance Trainee Report

Discord: LunakisLeaks Object of testing: #8627 Tier of Testing: 1 Date: 4/6/2024

Testing Process:

  1. Spawned at LCLK in C&D state
  2. Started the aircraft
  3. Ensured the systems work as usual
  4. Completed X2 flights

Negatives: N/A

Testing Results: Passed

Conclusions: LGTM