Closed frankkopp closed 2 months ago
Changes the units for LVars used in the fadec rewrite to "Number" and fixing all related usages of these vars.
Also changes A32NX and A380X turbine rotation animation behavior XML to use unit Number.
In general the team has decided to only use "Number" for LVars going forward and refactor existing non-number LVars at a later point in time.
Discord username (if different from GitHub): cdr_maverick
before: https://github.com/flybywiresim/aircraft/assets/16833201/f7fa29b0-9e2e-4010-8147-4650afcb95e4
after: https://github.com/flybywiresim/aircraft/assets/16833201/d9cb1153-32c6-4577-9977-4a34f29654f7
A32NX: Check turbine rotation animation for different N1 - best visible when starting or shutting down. Compare to current master to see if improved
A380X Check the Fadec related systems:
Check turbine rotation animation for different N1 - best visible when starting or shutting down.
This best tested together with other current PRs in the exp branch (@flogross89)
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.
Summary of Changes
Changes the units for LVars used in the fadec rewrite to "Number" and fixing all related usages of these vars.
Also changes A32NX and A380X turbine rotation animation behavior XML to use unit Number.
In general the team has decided to only use "Number" for LVars going forward and refactor existing non-number LVars at a later point in time.
Discord username (if different from GitHub): cdr_maverick
Video
before: https://github.com/flybywiresim/aircraft/assets/16833201/f7fa29b0-9e2e-4010-8147-4650afcb95e4
after: https://github.com/flybywiresim/aircraft/assets/16833201/d9cb1153-32c6-4577-9977-4a34f29654f7
Testing instructions
A32NX: Check turbine rotation animation for different N1 - best visible when starting or shutting down. Compare to current master to see if improved
A380X Check the Fadec related systems:
Check turbine rotation animation for different N1 - best visible when starting or shutting down.
This best tested together with other current PRs in the exp branch (@flogross89)
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.