flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

fix: Changing A380X LVar units used in fadec to Number #8628

Closed frankkopp closed 2 months ago

frankkopp commented 2 months ago

Summary of Changes

Changes the units for LVars used in the fadec rewrite to "Number" and fixing all related usages of these vars.

Also changes A32NX and A380X turbine rotation animation behavior XML to use unit Number.

In general the team has decided to only use "Number" for LVars going forward and refactor existing non-number LVars at a later point in time.

Discord username (if different from GitHub): cdr_maverick

Video

before: https://github.com/flybywiresim/aircraft/assets/16833201/f7fa29b0-9e2e-4010-8147-4650afcb95e4

after: https://github.com/flybywiresim/aircraft/assets/16833201/d9cb1153-32c6-4577-9977-4a34f29654f7

Testing instructions

A32NX: Check turbine rotation animation for different N1 - best visible when starting or shutting down. Compare to current master to see if improved

A380X Check the Fadec related systems:

Check turbine rotation animation for different N1 - best visible when starting or shutting down.

This best tested together with other current PRs in the exp branch (@flogross89)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page