The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
Most of our tsconfigs override typeRoots, which stops typescript from finding types in node_modules. Notably that prevented the jest types from being found so our tests were all red squiggles with no hints. This PR adds node_modules/@types to the typeRoots. There was also an issue with one of our dependencies (esbuild-style-plugin) requiring a @types/sass package which is malformed/empty, and caused typescript to complain about the typing config. The package seems to be unmaintained so we move to a fork that removes this useless dependency: https://github.com/g45t345rt/esbuild-style-plugin/issues/33.
Now our jest tests having typings.
As this PR only shuffles some typing deckchairs there is no QA.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
None required.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.
Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
Fixes #[issue_no]
Summary of Changes
Most of our tsconfigs override typeRoots, which stops typescript from finding types in node_modules. Notably that prevented the jest types from being found so our tests were all red squiggles with no hints. This PR adds node_modules/@types to the typeRoots. There was also an issue with one of our dependencies (
esbuild-style-plugin) requiring a@types/sasspackage which is malformed/empty, and caused typescript to complain about the typing config. The package seems to be unmaintained so we move to a fork that removes this useless dependency: https://github.com/g45t345rt/esbuild-style-plugin/issues/33.Now our jest tests having typings.
As this PR only shuffles some typing deckchairs there is no QA.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
None required.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.