search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.98k stars 1.04k forks source link

fix(AOC): prevent early clearing of OOOI-Data #8369 #8665

Closed cptnuss-ops closed 2 months ago

cptnuss-ops commented 4 months ago

Fixes #8369

Summary of Changes

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Simbrief flow

  1. Prepare Aircraft for flight, depart and land
  2. Shutdown at gate and check OOOI times are still present
  3. Prepare next flight and pushback to init new cycle
  4. Observe OOOI-Times on AOC-REVIEW page are cleared and a new leg is started

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
alepouna commented 3 months ago

Hey heads up, you have conflicting files 🙌

cptnuss-ops commented 3 months ago

Hey heads up, you have conflicting files 🙌

Sorry, my bad. I resolved the conflict.

alepouna commented 3 months ago

No worries what so ever, thank you for quick patch, I will add RTT labels so it can get QA'd!

noonebling commented 2 months ago

Quality Assurance Trainee Report

Discord : noonebling Object of testing: 8665 Tier of Testing : 1 Date : 06/07/2024

Testing Process:

  1. Loaded up flight, took off and landed
  2. Shutdown at gate and checked OOOI times
  3. Prepped next flight and pushbacked to init new cycle
  4. Checked if OOOI times are cleared and new leg is started

Negatives: N/A

Testing Results: Passed

Conclusions: Works as expected

cptnuss-ops commented 2 months ago

Ok, I'll close this PR and start again with a fresh codebase.