flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

fix: AOC INIT/REVIEW page - ON and OFF time logic. #8666

Open rahulrathnakumar opened 1 month ago

rahulrathnakumar commented 1 month ago

Partially Fixes #8369

Summary of Changes

Fixed condition under if (!this.aocTimes.on) to ensure proper triggering of landing block time.

Screenshots (if necessary)

Fixed the OFF and ON time discrepancy. Microsoft Flight Simulator Screenshot 2024 05 27 - 14 43 18 91

References

Additional context

Discord username (if different from GitHub): rahulrk

Testing instructions

  1. Load a flight plan in simbrief
  2. Import flight plan into EFB
  3. Go to the AOC INIT/REVIEW page, and hit the INIT LSK.
  4. Perform the takeoff. Observe the OFF time (Refresh the AOC INIT/REVIEW page by cycling pages).
  5. Perform the landing. The ON time field will populate once the aircraft gears make contact.

    How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
BravoMike99 commented 1 month ago

While you are at it, perhaps you might want to fix the block time too? If I'm not mistaken it is populated from simbrief instead of counting the block time (Time elapsed between OUT and IN ).

rahulrathnakumar commented 1 month ago

While you are at it, perhaps you might want to fix the block time too? If I'm not mistaken it is populated from simbrief instead of counting the block time (Time elapsed between OUT and IN ).

Sure thing, I'll fix that too.

rahulrathnakumar commented 1 month ago

While you are at it, perhaps you might want to fix the block time too? If I'm not mistaken it is populated from simbrief instead of counting the block time (Time elapsed between OUT and IN ).

Sure thing, I'll fix that too.

I have made the fix for this as well. I think @cptnuss-ops's fix to prevent the page from clearing, combined with my fixes should resolve this issue.