flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

refactor: move to official navigraph SDK for charts and authentication #8676

Closed Benjozork closed 1 week ago

Benjozork commented 2 weeks ago

This fixes some authentication issues with Navigraph by moving to their official SDK.

Summary of Changes

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
Saschl commented 2 weeks ago

Quality Assurance Report

Discord: Saschl Object of testing: https://github.com/flybywiresim/aircraft/pull/8676 Tier of Testing : 1 Date: 16/6/2024

Testing Process:

  1. Without unlinking and relinking:

    • Turn on EFB and import simbrief flight plan.
    • Override Simbrief username with a different one than mine and load flight plan again.
    • Opened and searched for different charts.
  2. Performed Unlink and Relink successfuly.

    • Performed same tests as above with success.

Negatives: Minor finding (Solved now):

Upon first load, SimBrief auto-import does not seem to work. When switching pages and returning to the OFP page, the import gets triggered:

image

Testing Results: Passed

Conclusions: LGTM