flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

fix(charts): plane symbol not visible #8684

Closed Saschl closed 6 days ago

Saschl commented 1 week ago

Fixes #[issue_no]

Summary of Changes

Fixes small regression that prevented the plane symbol on the charts from showing.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Open a chart in the EFB and make sure the yellow plane symbol is being shown and moves correctly. Also check that it is shown in the proper location (e.g. SIDS/STARS and Taxi charts)
  2. Use the "Fit chart to width" and "Fit chart to height" functionality and verify panning and zooming still works afterwards.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
Watsi01 commented 6 days ago

Non-QA Tester

I tested this PR cause Saschl asked me to.

Had the charts freeze on a regulary basis after commit 8676.

Freeze is gone with this PR.

Tested zooming, pushing all buttons ('fit to screen...' was the trigger of the freeze), draged the charts with the mouse. Loaded other charts, pinned them, loaded pinned charts. Deleted them and loaded new ones.

Everthing's working again.

Oh, and the plane symbol is back and on the right place too, of course!

Negatives: none

Testing results: passed.

alepouna commented 6 days ago

QA Report

Discord: alepouna Object of testing: #8684 Tier of Testing: 1 Date: 25/6/2024

Testing Process:

Testing Results: Passed