flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

fix(press): excess residual pressure warning with adirs off #8690

Closed mjuhe closed 3 days ago

mjuhe commented 1 week ago

Fixes #8642

Summary of Changes

After the introduction of PR #8511 and #8648, there was a condition where after landing, when switching off the ADIRS, the CPC was still sending an "excess residual pressure" signal to the FWC. This PR disables all signals when the ADIRS data is not valid.

I've also added a couple of accuracy changes to the excess residual pressure warning: 12 seconds delay (7 seconds to validate engines are off, and 5 to validate excess residual pressure) and trigger point at 0.036 PSI (from the FCOM).

The signal has been taken out of the discrete ARINC word and moved out of the CPC, as it's sent by an independent pressure switch.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): Commander Ga

Testing instructions

To check the warning does not appear when it shouldn't: Do a short flight landing at an airport at sea level in a day with high atmospheric pressure (you can try something like 1040hpa). Turn on APU and APU bleed, switch off engines and switch off the ADIRS.

Verify no "EXCESS CAB PR" warning appears in the ECAM. When switching off the ADIRS, the delta pressure indication turns to "XX".

To check the warning does appear when it should, with a delay: Do a short flight, after landing swtich on the APU and APU bleed. Change the MODE SEL of the pressurization system to manual, and close the outflow valve (about 50% should be more than enough). Switch off the engines. Ensure the "EXCESS CAB PR" appears after 12 seconds.

Note: to speed up testing, instead of doing a flight, you can manually change the FWC flight phase to 10 in Model Behaviors after switching off the engines.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
tracernz commented 3 days ago

Development Team QA Report

Discord: tracernz Object of testing: https://github.com/flybywiresim/aircraft/pull/8690 Tier of Testing: 1 Date: 28/6/2024

Testing Process:

Negatives: N/A

Testing Results: Passed

Conclusions: LGTM