search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.98k stars 1.04k forks source link

fix: airplane symbol with offsets #8700

Closed Saschl closed 3 months ago

Saschl commented 3 months ago

Fixes #[issue_no]

Summary of Changes

Fixes SVG position when bounding box is offset quite a bit from the top of the chart. Use x1, y2 from bounding box information now to place it properly.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Test e.g. LGAV VOR03Y FINAL and make sure the plane is visible. Also check taxi maps for accuracy.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
LunakisDev commented 3 months ago

Quality Assurance Trainee Report

Discord: LunakisLeaks Object of testing: #8700 Tier of Testing: 1 Date: 25/6/2024

Testing Process:

  1. Spawned at LGAV.
  2. Tested taxi map for accuracy.
  3. Tested all charts for visible plane icon.
  4. Completed 2 full flights 1) VOR 2) ILS - to test the chart plane icon accuracy

Negatives: N/A

Testing Results: Passed

Conclusions: LGTM