search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.93k stars 1.01k forks source link

fix(a380x): SD/FCTL page: Connect to existing data #8711

Closed flogross89 closed 2 hours ago

flogross89 commented 3 days ago

A380X only, no QA needed

Summary of Changes

Takes the existing F/CTL page and connects to the appropriate signals.

Changes:

Out of scope:

Screenshots (if necessary)

image

References

YouTube videos, FCOM

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
flogross89 commented 18 hours ago

@lukecologne thank you for your comments! About the power supply: Indeed EHA AC/DC seems to be supplying the EHAs (didn't know that), but the EHA busses are not yet implemented within the WASM systems. I added a comment to remind ourselves that we should add it at a later point in time, but at the moment I don't have the knowledge to do it.

Since AC 3 supplies AC EHA most of the time, I would keep it as the best approximation which we can have right now. Would that be OK for you?

lukecologne commented 18 hours ago

To my knowledge, both the AC and DC EHA busses are implemented. For the AC EHA bus, it is probably labeled as 247XP (the FIN designation). So the simvar to check the bus status would be A32NX_ELEC_AC_247XP_BUS_IS_POWERED

flogross89 commented 17 hours ago

To my knowledge, both the AC and DC EHA busses are implemented. For the AC EHA bus, it is probably labeled as 247XP (the FIN designation). So the simvar to check the bus status would be A32NX_ELEC_AC_247XP_BUS_IS_POWERED

ah, that's why I didn't find it. 247XP exists, I'm using that from now on.

flogross89 commented 5 hours ago

Noticed some things during a quick test that are not directly related to the PR but should probably be fixed in here.

Github wouldn't let me place a comment there, but it looks like the THS sign for UP/DN is flipped when using the sim's convention. Would be great if that could be fixed

ah good spot, thanks! changed both, should be fine now