search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
4.98k stars 1.04k forks source link

fix(mcdu): remove v-speed auto-fill #8712

Closed tracernz closed 3 months ago

tracernz commented 3 months ago

Fixes #[issue_no]

Summary of Changes

Removes the V-speed auto-fill function in the MCDU, as it is no longer relevant after https://github.com/flybywiresim/aircraft/pull/8678 merges and not realistic.

Not to be merged until after #8678.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Try the V-speed LSKs on PERF TO with empty scratchpad and ensure you get "FORMAT ERROR". Try entering speeds properly and ensure it works. Make sure departure runway is set in the flightplan, ZFW and FOB are entered on INIT B (or just ZFW if engines running). Try entering speeds that are too low (but still valid within the range 90-Vmo) and ensure you get a message saying they're too low on the scratchpad.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page
BlueberryKing commented 3 months ago

Nice work! This will require an update to the documentation and clear communication from our side. Everyone is used to this working in our plane.

tracernz commented 3 months ago

Yep, the suggestion for this PR actually came out of writing the docs 👍.

alepouna commented 3 months ago

QA Report

Discord: alepouna Object of testing: #8712 Tier of Testing: 1 Date: 28/6/2024

Testing Process:

Testing Results: Not Passed

Negatives: No "speed too low" scratchpad amber message shown

tracernz commented 3 months ago

Oops, I missed a step. You have to enter flaps before V-speeds can be checked. image

alepouna commented 3 months ago

Oops, I missed a step. You have to enter flaps before V-speeds can be checked.

Flaps were entered (as I am pretty sure the calculator doesnt work anyways without one) I used 2 iirc.

tracernz commented 3 months ago

And the accepted range is 90-Vmo.

alepouna commented 3 months ago

QA Report

Discord: alepouna Object of testing: https://github.com/flybywiresim/aircraft/pull/8712 Tier of Testing: 1 Date: 28/6/2024

Testing Process:

Testing Results: Passed