search

flybywiresim / aircraft

The A32NX & A380X Project are community driven open source projects to create free Airbus aircraft in Microsoft Flight Simulator that are as close to reality as possible.
https://flybywiresim.com
GNU General Public License v3.0
5.15k stars 1.12k forks source link

fix(cdu): correct tmply fpln activation logic in airways page #9562

Open robertxing2004 opened 2 days ago

robertxing2004 commented 2 days ago

Summary of Changes

Extension of #9148

The airways page now only creates a tmpy fpln after a valid segment is entered; either an airway and a terminating waypoint, or an airway followed by an intersecting airway. Prior to either of these two conditions being met, there is no pending flight plan, and pressing return will not result in a false tmpy state on the fpln page.

Screenshots (if necessary)

References

Additional context

While troubleshooting this issue, I discovered bugs #9560 and #9561, but as it stands this PR only fixes the tmpy fpln activation logic. Those bugs can be addressed in a separate PR.

Discord username (if different from GitHub): robeet

Testing instructions

  1. Spawn anywhere and start a fpln from the mcdu
  2. After entering a STAR and transition, enter the airways page and make modifications
  3. Verify that there is no option to erase or insert until a terminating waypoint or intersecting airway has been entered
  4. Returning any time before the above two conditions should not create a tmpy fpln

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page