flybywiresim / discord-bot-utils

Utilities Discord Bot created for the FlyByWire Discord server.
https://flybywiresim.com/
GNU Affero General Public License v3.0
5 stars 7 forks source link

chore: configure vscode workspace #68

Closed ExampleWasTaken closed 3 months ago

ExampleWasTaken commented 4 months ago

...this PR is 100% identical to #66. While re-structuring my branch setup I renamed the branch and didn't think of the fact that this would close the PR 😂

Description

This PR configures the VS Code workspace to ensure a correct environment setup. It also adds recommendations for the ESLint and .editorconfig extensions as they greatly enhance the DX.

Test Results

No code has been modified.

pdellaert commented 4 months ago

Probably need some check with other devs to see if they have an issue. I'll check this out myself as well

ExampleWasTaken commented 4 months ago

Yep, I'm totally open for suggestions, so far this is based on the settings we have in the aircraft repo.

benw202 commented 4 months ago

All looks good to me, I don't use VS code but I'm happy with it if it's based off of the aircraft repo!

ExampleWasTaken commented 3 months ago

The project breaks with TS v^5.5.x due to a bug fix added in that version. VSCode, by default, uses the TS version it ships with, so we need to force it to use the version of the workspace (the one in node_modules).

see #78