search

flybywiresim / installer

FlyByWire Simulations installer
GNU General Public License v3.0
104 stars 92 forks source link

feat: read config json from documents dir #478

Closed Saschl closed 1 month ago

Saschl commented 1 month ago

Needs https://github.com/flybywiresim/simbridge/pull/121 to be released first.

Summary of Changes

Screenshots (if necessary)

Additional context

Discord username (if different from GitHub):

Saschl commented 1 month ago

grafik In the about page, the html parsing is not implemented. Also, the fallback is missing for the resources folder which would be helpful to access to move the files before updating.

Fixed the first, thanks 👍 About the fallback: we could also split the installer-data PR into two.

  1. Only update the description to raise awareness -> installer works as before
  2. Update the path together with the simbridge release -> installer will open the new directory with the resources button
FoxtrotSierra6829 commented 1 month ago

Open for discussion, I'd rather prefer a solution that is not strictly time-based since not everyone uses the FlightSim on a daily basis

Saschl commented 1 month ago

Open for discussion, I'd rather prefer a solution that is not strictly time-based since not everyone uses the FlightSim on a daily basis

Yep, I see the point. I just want to keep the change as minimal as possible. Please check again, I've added another directories entries in the config which points to the old one. For me it's a good compromise :D

Otherwise I would think it's too much. If we go with my original proposal, only people who ignore the update will have an issue with the "Resources" button in the installer. The configuration is supporting both. I would consider that acceptable.

image