search

flycastpartnersinc / FreshservicePS

Powershell Module to interface with Freshworks Freshservice REST API.
MIT License
23 stars 5 forks source link

Removing 1 of 2 named connections all connections are removed. #27

Open Showkilr opened 2 weeks ago

Showkilr commented 2 weeks ago

When removing 1 connection and there are only 2 connections within the configuration file the config file is removed.

Expected Behavior

The last remaining connections should be re-written to the config file

Current Behavior

when the connections count is 2 the file is just removed. if the connections count is > 2 then the removal works as expected

Possible Solution

Change the Line 73 in Remove-FreshServiceConnection.ps1

Current

if ($environments.Count -gt 0) {

NEW

if (($environment) -or ($environment.count -gt 0)) {

Steps to Reproduce (for bugs)

  1. New-FreshServiceConnection -Name "acme1" -ApiKey "acme1" -Tenant 'acme1' -Environment Sandbox
  2. New-FreshServiceConnection -Name "acme2" -ApiKey "acme2" -Tenant 'acme2' -Environment Sandbox
  3. Remove-FreshServiceConnection -Name "acme2"

Context

when preforming removal of the sandbox API connection you have to redefine the production connection. More of an Annoyance.

Your Environment