search

flycheck / flycheck-inline

Display Flycheck errors inline
GNU General Public License v3.0
137 stars 10 forks source link

Align every line of the error message to the same column #3

Closed mssdvd closed 6 years ago

mssdvd commented 6 years ago

Currently only the first line is aligned to the error's column (see the screenshot). Is it possible to align all the rows to the same column of the first row? image

fmdkdd commented 6 years ago

Hmm, I cannot reproduce. Here is what I get with rust 1.28:

flycheck-inline-3

fmdkdd commented 6 years ago

And here is a multi-line warning:

flycheck-inline-3-warn

mssdvd commented 6 years ago

I apologise for not giving a more comprehensive description. I was using lsp-mode + lsp-ui + this patch + (setq lsp-ui-sideline-show-flycheck nil).

fmdkdd commented 6 years ago

Alright, thanks for clarifying. My guess is that lsp-mode is producing error messages that contain newlines, and flycheck-inline only pads the first line of an error message, not all the lines.

Can you try the patch at #4 and see if that works for you?

mssdvd commented 6 years ago

It works to me. Thank you!

fmdkdd commented 6 years ago

@mssdvd Thanks for confirming, I merged the change.