search

flycheck / flycheck-ocaml

OCaml support for Flycheck using Merlin
GNU General Public License v3.0
22 stars 6 forks source link

Fix travis #8

Closed drvink closed 1 year ago

drvink commented 6 years ago

Flycheck itself will need an update in order for tests to pass on Emacs 24.3: flycheck-ert uses define-error, but Emacs 24.3 didn't have that. I'll make a PR for that on the Flycheck repo.

drvink commented 6 years ago

The tests are passing on everything but 24.3 (which was probably just because MELPA doesn't have the updated Flycheck still) and the snapshot version (which looks like some other problem related to the build environment) now.

drvink commented 6 years ago

The 24.3 tests are still failing due to define-error--it looks like json also uses it. Flycheck itself doesn't use define-error, so I guess I'll just add the defun to the test file here--better than cluttering flycheck's code.

bbatsov commented 1 year ago

I guess it's a bit too late, but better late then never. Travis no longer exists at this point and we'll need to replace it with something else (e.g. GHA).