flycrane / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Build fail with r115, lz4.h missing #124

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Have a clean system without lz4 installed
2. make

Original issue reported on code.google.com by sebastien.luttringer on 23 Mar 2014 at 11:48

Attachments:

GoogleCodeExporter commented 8 years ago
mmmh, I just made this test before publishing r115, and now that I'm doing it 
again (1. Have a clean system without lz4 installed 2. make), it seems to work 
fine on my test Linux configuration.

What test condition could make the result different ?

Original comment by yann.col...@gmail.com on 23 Mar 2014 at 11:53

GoogleCodeExporter commented 8 years ago
ok, got it (I think),
it seems the CFLAGS fix disappeared from r115.
Quite strange...

Original comment by yann.col...@gmail.com on 23 Mar 2014 at 11:58

GoogleCodeExporter commented 8 years ago
You probably have lz4.h in your include lookup path.

Original comment by sebastien.luttringer on 23 Mar 2014 at 11:59

GoogleCodeExporter commented 8 years ago
I don't think the CFLAGS fix is gone, see the diff. But the programs/Makefile 
don't include a -I..!

Original comment by sebastien.luttringer on 23 Mar 2014 at 12:02

Attachments:

GoogleCodeExporter commented 8 years ago
> You probably have lz4.h in your include lookup path.

nope, checked that.
My current guess is that it is related to CFLAGS issue, because :
cc       -I. -std=c99 -O3 -Wall -W -Wundef -DLZ4_VERSION=\"r115\" ../lz4.c 
../lz4hc.c bench.c xxhash.c lz4io.c lz4cli.c -o lz4c
is incorrect 
(should -I..)

Original comment by yann.col...@gmail.com on 23 Mar 2014 at 12:02

GoogleCodeExporter commented 8 years ago
In programs directory, lz4.h is in ".." directory not in ".", do it's not in 
your lookup path.

Original comment by sebastien.luttringer on 23 Mar 2014 at 12:15

GoogleCodeExporter commented 8 years ago
release candidate r116, as published in r125, is supposed to solve this issue 
too

Original comment by yann.col...@gmail.com on 23 Mar 2014 at 12:21

GoogleCodeExporter commented 8 years ago

Original comment by yann.col...@gmail.com on 23 Mar 2014 at 12:21

GoogleCodeExporter commented 8 years ago
Fixed into r116

Original comment by yann.col...@gmail.com on 24 Mar 2014 at 9:01