flydelabs / flyde

🌟 Open-source, visual programming for developers. Includes a VS Code extension, integrates with existing TypeScript code, browser and Node.js.
http://www.flyde.dev/
Other
1.97k stars 48 forks source link

resolving of ui bundle missed path by 1 level #120 #124

Closed akim-muto closed 4 months ago

akim-muto commented 5 months ago

New breaking change here

   ditorComponentBundlePath: "../../../macro.tsx" → ditorComponentBundlePath: "../../macro.tsx"

vercel[bot] commented 5 months ago

Someone is attempting to deploy a commit to the Flyde Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **flyde-playground** | ⬜️ Ignored ([Inspect](https://vercel.com/flyde/flyde-playground/HQXqeWGfq3EF63fYtC2uiRfqh5mM)) | [Visit Preview](https://flyde-playground-git-fork-project-coc-resolving-bu-a3f009-flyde.vercel.app) | | Jun 13, 2024 10:31am |
akim-muto commented 4 months ago

Response to review. Thanks for your time.

GabiGrin commented 4 months ago

@akim-muto reviewed again, this should work - left some improvement comments for the code itself

akim-muto commented 4 months ago

Oh, you meant to leave it in the code comments. I thought need to put out a Warning.

I'm going!

GabiGrin commented 4 months ago

@akim-muto great job, tested and backwards compat. is working great 👍