search

flydev-fr / Duplicator

🧬 Duplicator for ProcessWire. Duplicate, backup and transfer an entire site from one location to another
28 stars 7 forks source link

support s3 prefixes, add additional logging #8

Closed StanLindsey closed 3 years ago

StanLindsey commented 3 years ago

This PR adds an additional config field that allows you to set the prefix / sub directory of an S3 object.

This allows you to have a single bucket for example named "my-lovely-backups" and within that have subfields for each site you are backing up. You can then have: my-lovely-backups/siteA/backup1.package.zip
my-lovely-backups/siteA/backup2.package.zip
my-lovely-backups/siteB/backup1.package.zip
my-lovely-backups/siteB/backup2.package.zip
etc etc.

This PR also adds some additional logging in areas I found useful when making these changes.

flydev-fr commented 3 years ago

Thanks @StanLindsey , nice addition !

Could you send the PR on the dev branch ? I checked your changes and it's green to be merged on the dev version.

StanLindsey commented 3 years ago

@flydev-fr - done 👍

StanLindsey commented 3 years ago

@flydev-fr - realised i hadn't done that very well as all my original development was on the master branch - cherry-picked my changes onto dev and repushed 👍

flydev-fr commented 3 years ago

Thanks @StanLindsey merged !