search

flyerhq / react-native-link-preview

Fully customizable preview of the URL extracted from the provided text.
MIT License
125 stars 30 forks source link

LayoutAnimation: consider including react-native-reanimated #24

Closed hirbod closed 2 years ago

hirbod commented 2 years ago

https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/layout_animations

And maybe make those animations configureable. I understand that you want to keep dependencies low, but Reanimated is like the standard toolset for every app I know.

demchenkoalex commented 2 years ago

Hey, thanks for the suggestion! I had thoughts to include react-native-reanimated as a dependency to all projects we have here, but then I remembered how React Navigation actually removed it, and in large projects reanimated is usually not being updated (I bet a lot of people are still on v1) so I am not sure about that now..

hirbod commented 2 years ago

For now, it seems like LayoutAnimation by Reanimated is broken on FlatLists. It just works for the visible, unscrolled part and not for the overflowed. I would consider it unstable for now.

I think we should keep an eye on it. Reanimated is actually kinda the bare metal standard nowadays, even though I am not 100% happy with the v2 performance at every aspect, but I am sure it will be super stable soon.

demchenkoalex commented 2 years ago

Will close this for now, but discussion can be continued later.