search

flyerhzm / rails_best_practices

a code metric tool for rails projects
http://rails-bestpractices.com
MIT License
4.16k stars 276 forks source link

False positive for UseMultipartAlternativeAsContentTypeOfEmailCheck #196

Closed schasse closed 10 years ago

schasse commented 10 years ago

Hi,

I have got the following setup of email templates

template.html.haml
template.en.text.haml
template.de.text.haml

content type in email headers is as expected 'multipart/alternative', but ther check says that you should use multipart/alternative as content_type of email.

EDIT: I just updated rails_best_practices to version 0.4.4 and can still confirm that false positive.

flyerhzm commented 10 years ago

@schasse it should be fixed on HEAD code, please let me know if it works for you.

okolomoets commented 5 years ago

Hi,

This issue is still reproducible for me.

My current version of rails_best_practices is 1.19.4