search

flyerhzm / rails_best_practices

a code metric tool for rails projects
http://rails-bestpractices.com
MIT License
4.16k stars 276 forks source link

Standarized exit code #288

Closed mensfeld closed 7 years ago

mensfeld commented 7 years ago

Hey, up until now the exit code was equal to the number of errors found. I don't think it is right as exit codes aren't meant to be used that way. What I suggest is to make them similar to Rubocop: 0 for no offenses and 1 for 1 or more.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3097faaa5d18388fe9e199cd621a729ea870270 on mensfeld:exit_code into b6ff587e02c5b3df2b00de16b6fbbcd6f0c3a23a on railsbp:master.