flyerhzm / rails_best_practices

a code metric tool for rails projects
http://rails-bestpractices.com
MIT License
4.17k stars 276 forks source link

Update to require_all 2.x #313

Closed hlascelles closed 6 years ago

hlascelles commented 6 years ago

This change upgrades require_all to version 2.x

It has been determined that require_all's original system of using NameError errors to give a load sequence is unsafe. Version 2.x fixes that.

To accommodate it, some necessary require_rel lines have been added.

joehorsnell commented 6 years ago

Hi @flyerhzm - would you be able to push a new version of rails_best_practices to RubyGems with this fix in? Many thanks.

flyerhzm commented 6 years ago

@joehorsnell I just released 1.19.2

joehorsnell commented 6 years ago

Brilliant - thank you @flyerhzm.