flyfire / android-notifier

Automatically exported from code.google.com/p/android-notifier
0 stars 0 forks source link

Locale Notification Plugin does only work if title is set #194

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If I leave the title empty and just fill the notification description (body 
text), nothing happens.

Original issue reported on code.google.com by peter.v...@gmail.com on 30 Sep 2010 at 1:45

GoogleCodeExporter commented 9 years ago
I was doing this from within Tasker.

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 1:46

GoogleCodeExporter commented 9 years ago
Hmm I just tested and am unable to reproduce - the notification gets sent just 
fine if one (but not both) of the fields is empty. Since you're playing with 
the code, perhaps you could do some debugging for this issue?

Original comment by rdamazio@gmail.com on 30 Sep 2010 at 2:27

GoogleCodeExporter commented 9 years ago
so far I only imported the project to eclipse but I'd love to.
I assume I can not do remote debugging or something like that :) How can I log 
things like I would do sysouts if I had a console?

I just found out that filling only the title works, but only the description 
does not.
So it's just the one way around that's faulty

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 3:44

GoogleCodeExporter commented 9 years ago
See this about notifications without description not shown: 
http://code.google.com/p/android-notifier/issues/detail?id=44&can=1&q=third#c21

Description should be a required parameter.

Original comment by lehph...@gmail.com on 30 Sep 2010 at 4:09

GoogleCodeExporter commented 9 years ago
on linux it works exactly the other way around as it seems. Using libnotify, 
not the system default. Rodrigo, that might actually be the explonation for 
this :)

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 4:18

GoogleCodeExporter commented 9 years ago
Oh yes. System default delivers the notification no matter which of the 2 is 
empty.
Libnotify only works if the title is NOT empty

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 4:20

GoogleCodeExporter commented 9 years ago
I'd say the only safe way is to make both fields mandatory. Too bad it has to 
be that way, but that will work for everyone in every situation.

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 4:22

GoogleCodeExporter commented 9 years ago
On the mac, you need one of the two. I think that's the most flexible way and 
should be done across all systems. If a specific display method requires one of 
them, either use an empty string (if allowed) or use a default string like 
"Remote Notification".

Original comment by rdamazio@gmail.com on 30 Sep 2010 at 5:24

GoogleCodeExporter commented 9 years ago
I don't know why people would not set both in a notification, but I'll set 
default values so they are always displayed in all OSes.

Original comment by lehph...@gmail.com on 30 Sep 2010 at 5:43

GoogleCodeExporter commented 9 years ago
Sure. I just mean right now the user might wonder why the notification doesn't 
appear (e.g. on linux with libnotify, and as it seems in windows too). I think 
a one liner could help like "Depending on your plattform and settings, you 
might need to enter text in both fields." Maybe right below those two fields in 
the local notification plugin? Just an idea.

Original comment by peter.v...@gmail.com on 30 Sep 2010 at 5:45

GoogleCodeExporter commented 9 years ago
Changed to show "Android Notifer" in title and "No description" in description 
if they are null or empty (length == 0).

Original comment by lehph...@gmail.com on 30 Sep 2010 at 6:01

GoogleCodeExporter commented 9 years ago
I also provided a patch in Issue 15 for the android app to warn the user about 
this behaviour. So if you want to let Mac users have it with only one of the 
two fields, you can do that now without risking bugreports about possible 
problems on other plattforms. aka. "We warned you"

Original comment by peter.v...@gmail.com on 1 Oct 2010 at 5:57

GoogleCodeExporter commented 9 years ago
solved. close?

Original comment by peter.v...@gmail.com on 7 Oct 2010 at 7:29

GoogleCodeExporter commented 9 years ago

Original comment by rdamazio@gmail.com on 13 Oct 2010 at 3:24