search

flyingcircusio / batou

batou is a universal, fractal deployment utility using Python.
https://batou.readthedocs.org
Other
47 stars 11 forks source link

fix: SyncDirectory verification #410

Closed PhilTaken closed 10 months ago

PhilTaken commented 10 months ago

Add a check to the SyncDirectory component for the target directory.

The SyncDirectory component's verify() stage fails when the target directory does not exist yet, because it uses rsync to determine if there is a diff between left and right. In cases where the target directory is part of the deployment and has thusly not been created yet this leads to unexpected errors.

PhilTaken commented 10 months ago

Looks good in general, but could you please add a test case?

done

ctheune commented 10 months ago

Great. Thanks!

@elikoga can you merge and backport?

elikoga commented 10 months ago

@ctheune I can open a backport PR, but merging is restricted for me

ctheune commented 10 months ago

Ok, I'm merging this one then, would appreciate the backport.