search

flyingcircusio / batou

batou is a universal, fractal deployment utility using Python.
https://batou.readthedocs.org
Other
47 stars 12 forks source link

JSONContent integration incomplete #433

Open zagy opened 6 months ago

zagy commented 6 months ago

I think it's meant to be used just like this, e.g. self += JSONContent(…) but that's inconsistent with text content where one uses File(…). So my expectation would be either File(content=JSONContent(…)) or File(json=…)

elikoga commented 6 months ago

See https://github.com/flyingcircusio/batou/blob/0a3096117f63455bb040825f577a887a928c16ff/src/batou/lib/file.py#L113C17-L124 probably

zagy commented 6 months ago

See https://github.com/flyingcircusio/batou/blob/0a3096117f63455bb040825f577a887a928c16ff/src/batou/lib/file.py#L113C17-L124 probably

Exactly.