search

flyingcircusio / batou_ext

A library of batou extensions.
Other
4 stars 1 forks source link

[FC-40616] Fix tests #191

Closed Ma27 closed 1 month ago

Ma27 commented 1 month ago

Mailpit always expects a basic auth component, so we add one to the deployment.

Alsio noticed that env_name isn't a namevar for HTTPBasicAuth, so fixed up the docstring to reflect that.

PhilTaken commented 1 month ago

LGTM. indirectly related to this pr but the extra basicauth component here is only required because there is no way to run mailpit without basic auth

Ma27 commented 1 month ago

indirectly related to this pr but the extra basicauth component here is only required because there is no way to run mailpit without basic auth

That was done on purpose after a discussion with @frlan a while ago: we had several installations of Mailhog that didn't have any basic auth (w/o a good reason), so I figured the new component should force that.