flyinghead / flycast

Flycast is a multiplatform Sega Dreamcast, Naomi, Naomi 2 and Atomiswave emulator
GNU General Public License v2.0
1.39k stars 169 forks source link

[Libretro] AI service (translation) images are received upside down #1419

Closed Sanaki closed 7 months ago

Sanaki commented 7 months ago

Platform / OS / Hardware: x86_64 Linux (Garuda/Arch)

Github hash: 44fa364f36c43bed19b055096600f075c656f78c

Hardware: GTX 1060 6GB

Description of the Issue

Images received by the AI translation service are flipped vertically, preventing successful translation.

Debugging Steps Tested

Logs Gathered

Screenshots

image2 Screenshot_20240223

flyinghead commented 7 months ago

The image presented by Flycast to RetroArch is correct (not upside down) and screenshots also have the correct orientation. So it doesn't look like a Flycast issue, nor something that can be fixed in the core.

bslenul commented 7 months ago

Hm yeah, just tested with a PS1 Japanese game with Beetle PSX HW and SwanStation cores and in both cases the translation server received the screenshot upside-down. With PCSX ReARMed or Beetle PSX non-HW (SW renderer) or Beetle PSX non-HW no issue, so probably a RetroArch issue with how it sends HW renderer screenshots 🤔

edit: Seems to work fine with RetroArch 1.16.0 so looks like a "recent" regression but I think this can be closed since it doesn't seem to have anything to do with Flycast. RetroArch issue opened: https://github.com/libretro/RetroArch/issues/16275

PCdasala commented 7 months ago

just to complement, when I use dx11 or another dx the message is "clould not read viewport", with vulcan a meaningless translation attempt occurs and the game continues to bug and close. This only happens on dreamcast and ps2 ![Uploading IMG_3905.jpeg…]()

Sanaki commented 7 months ago

Given bslenul verifying this is a RetroArch issue, I'm closing this one.