flyinghead / flycast

Flycast is a multiplatform Sega Dreamcast, Naomi, Naomi 2 and Atomiswave emulator
GNU General Public License v2.0
1.5k stars 176 forks source link

Sega NAOMI 2 Music is louder than usual. #1513

Open TheCoolPup opened 6 months ago

TheCoolPup commented 6 months ago

Github hash: e2e9a54

Hardware: AMD Ryzen 5600H @3.3GHz, Nvidia RTX 3050ti Laptop GPU

i noticed in mostly naomi 2 games, for example soul surfers and beach spikers,

https://github.com/flyinghead/flycast/assets/91135037/3ab11846-b5b9-49bf-a632-799c461b6789

sometimes the in game gets way louder than it needs to be and overlaps the sound effects, seems to be a on and off basis

TheCoolPup commented 6 months ago

volume warning btw

CO-Windler commented 2 months ago

In Sega Driving Simulator the steering wheel is miswired to the volume control, so steering to the left cranks up sounds to the max while steering right turns it silent. Apparently some analogue game inputs got mixed up. This may be a related issue.

kihato commented 2 months ago

This appears to be a regression due to 7cc77b1.

flyinghead commented 1 month ago

Fixed on master

TheCoolPup commented 1 month ago

Thank you

kihato commented 1 month ago

There seems to be an issue where the sound is sometimes biased towards the right channel.

https://github.com/user-attachments/assets/e59eeacc-1d9b-4a3e-8589-9f3a550a8840

Set the region to Japan and launch Soul Surfer. There is a noise when the controls explanation screen is displayed for the second time. There is an audio glitch in the right channel on the hard ranking screen immediately after the fourth controls explanation screen.

From the hard ranking screen: soulsurf.zip

flyinghead commented 1 month ago

Audio glitches should be fixed on master. This was due to audio samples being played before there are copied to audio RAM. So data is now transferred in chunks at regular intervals, similarly to what's done with the GDROM. However there is a significant risk of regression with all naomi (1/2) and atomiswave games.

kihato commented 1 month ago

Thanks for fixing it. The audio glitches on the Soul Surfer controls and hard ranking screen are now fixed. Unfortunately the audio glitches on Beach Spikers replays etc still seem to happen occasionally.

flyinghead commented 1 month ago

Unfortunately I can't seem to reproduce the issue on Beach Spikers. I haven't played for hours but no issue with the sound during replays.

TheCoolPup commented 1 month ago

did some testing and the audio issues seem to be gone, thank you for fixing them flyinghead. :)

TheCoolPup commented 1 month ago

can confirm the issue still happens on beach spikers

TheCoolPup commented 1 month ago

https://github.com/user-attachments/assets/3f0e498a-b478-450f-9496-1a991b0f5224

flyinghead commented 1 month ago

If only I could get a savestate to reproduce this audio glitch at will...

TheCoolPup commented 1 month ago

Can’t right now but later if it pops up again, I’ll send a savestate

flyinghead commented 1 month ago

The thing is: I need a savestate before the audio glitch happens, which is almost impossible since it doesn't seem to happen that often.